Remove all_valid/all_invalid from Validity#6926
Merged
Conversation
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
robert3005
reviewed
Mar 12, 2026
| .unsliced_validity | ||
| .slice(array.slice_start()..array.slice_stop())? | ||
| .all_valid(sliced_len)?; | ||
| let has_nulls = !matches!( |
Contributor
There was a problem hiding this comment.
You have to change the comment? This previously was specifically checking the sliced range
Contributor
|
Did we not care in the other cases? I think I miss the place where ZSTD and Duckdb exporter enforced a tighter constraint. Maybe the change here is to ask for validity_mask? |
robert3005
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These functions were performing hidden compute without an ExecutionCtx.
I have also removed PartialEq, since that was executing arrays!
There now exists a Validity::mask_eq (similar to array_eq) which will evaluate only if necessary